Fix incorrect Gradle project configuration.#1087
Merged
sriram-mv merged 1 commit intoaws:developfrom Mar 27, 2019
zhangzhx:develop
Merged
Fix incorrect Gradle project configuration.#1087sriram-mv merged 1 commit intoaws:developfrom zhangzhx:develop
sriram-mv merged 1 commit intoaws:developfrom
zhangzhx:develop
Conversation
sriram-mv
reviewed
Mar 27, 2019
...tter-aws-sam-hello-java-gradle/{{cookiecutter.project_name}}/HelloWorldFunction/build.gradle
Show resolved
Hide resolved
sriram-mv
approved these changes
Mar 27, 2019
sanathkr
approved these changes
Mar 27, 2019
Contributor
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
Here is my summary of what I understand from the change. Approving based on this:
- dependencies are updated to remove annotations like not-null, lombok etc
- sourceSet path is set wrong which prevents IDEs from inferring the source code location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This issue is reported in AWS Toolkit JetBrains, but the root cause is the Gradle template
aws/aws-toolkit-jetbrains#854
Description of changes:
Remove the redundant
sourceSetsconfiguration and replace the deprecated methods.Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.