Skip to content

fix(init): Add runtime to template when dotnetcore runtime is asked for#1107

Merged
sriram-mv merged 1 commit intoaws:developfrom
jfuss:fix-dotnetcore-init
Apr 9, 2019
Merged

fix(init): Add runtime to template when dotnetcore runtime is asked for#1107
sriram-mv merged 1 commit intoaws:developfrom
jfuss:fix-dotnetcore-init

Conversation

@jfuss
Copy link
Contributor

@jfuss jfuss commented Apr 9, 2019

Issue #, if available:
N/A

Description of changes:
sam init --runtime dotnetcore produced a template without a Runtime, making the template invalid. This change removes an else if case in the template generation to allow always producing the latest dotnetcore runtime. The cli (click) will validate the options before cookiecutter runs, so we don't need strict match checks expect for the none latest cases (in this case for dotnetcore2.0).

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv merged commit d194e59 into aws:develop Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants