Skip to content

Less confusing error msg for not from aws world people #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfuss merged 3 commits into from
Jul 26, 2019
Merged

Less confusing error msg for not from aws world people #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af03c01
Update cloudformation_command.py
zafarella Apr 25, 2019
da910c7
Update cloudformation_command.py
zafarella Apr 25, 2019
110f68d
Fix unit tests
jfuss Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samcli/lib/samlib/cloudformation_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ def find_executable(execname):
except OSError as ex:
LOG.debug("Unable to find executable %s", name, exc_info=ex)

raise OSError("Unable to find AWS CLI installation under following names: {}".format(options))
raise OSError("Cannot find AWS CLI installation, was looking at executables with names: {}".format(options))
3 changes: 2 additions & 1 deletion tests/unit/lib/samlib/test_cloudformation_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ def test_must_raise_error_if_executable_not_found(self, platform_system_mock, po
with self.assertRaises(OSError) as ctx:
find_executable(execname)

expected = "Unable to find AWS CLI installation under following names: {}".format(["foo.cmd", "foo.exe", "foo"])
expected = "Cannot find AWS CLI installation, was looking at executables with names: {}".format(
["foo.cmd", "foo.exe", "foo"])
self.assertEquals(expected, str(ctx.exception))

self.assertEquals(popen_mock.mock_calls, [
Expand Down