fix(invoke/build): Allow AmazonLinux1803 Layer and fail when AmazonLinux1703 Layer is provided#1181
Merged
jfuss merged 2 commits intoaws:developfrom May 15, 2019
Merged
Conversation
…nux1703 Layer is provided DockerLambda only supports one version of a container. Recently this was updated to AmazonLinux1803 but (at the time of writing) the Lambda Service is still using AmazonLinux1703. Given that, SAM CLI will now fail if the arn:aws:lambda:::awslayer:AmazonLinux1703 Layer Arn is provided. If arn:aws:lambda:::awslayer:AmazonLinux1803 Layer Arn is provided, we simply ignore it when reading the Layer Definition on a Function. This scenerios happen in both build and invoke related commands.
awood45
approved these changes
May 15, 2019
sanathkr
approved these changes
May 15, 2019
sanathkr
approved these changes
May 15, 2019
Contributor
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
LGTM. Hope Travis is LGTM too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DockerLambda only supports one version of a container. Recently this was updated to AmazonLinux1803
but (at the time of writing) the Lambda Service is still using AmazonLinux1703. Given that, SAM CLI
will now fail if the arn:aws:lambda:::awslayer:AmazonLinux1703 Layer Arn is provided. If
arn:aws:lambda:::awslayer:AmazonLinux1803 Layer Arn is provided, we simply ignore it when reading
the Layer Definition on a Function. This scenerios happen in both build and invoke related commands.
Issue #, if available:
N/A
Description of changes:
See git commit above.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.