chore: Docker SDK minimum version should be 3.7.0#1214
Merged
jfuss merged 2 commits intoaws:developfrom Jun 7, 2019
Merged
Conversation
To support Docker Proxy Config (aws#1196)
Contributor
Author
|
I reviewed the changelog of Docker-Py library (https://github.com/docker/docker-py/releases) since v3.3.0. No breaking changes and no warnings or anything. The list of features & bug fixes look benign to me. |
jfuss
reviewed
Jun 7, 2019
requirements/base.txt
Outdated
| cookiecutter~=1.6.0 | ||
| aws-sam-translator==1.10.0 | ||
| docker>=3.3.0 | ||
| docker>=3.7.0 |
Contributor
There was a problem hiding this comment.
If we are not planning to update to the latest, can we bump this (and pin) to the latest 3.x 3.7.2
Contributor
Author
There was a problem hiding this comment.
Actually, we should stick to ~3.7.0 which will upgrade patch versions...
Contributor
There was a problem hiding this comment.
That means build are not deterministic though.
Contributor
Author
There was a problem hiding this comment.
Yes, but patch versions shouldn't break..
jfuss
approved these changes
Jun 7, 2019
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Just waiting for Travis to pass before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support Docker Proxy Config (#1196)
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.