Skip to content

fix: default to nodejs10.x on init #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sriram-mv merged 3 commits into from
Jul 30, 2019
Merged

fix: default to nodejs10.x on init #1275

sriram-mv merged 3 commits into from
Jul 30, 2019

Conversation

@sriram-mv
Copy link
Contributor

@sriram-mv sriram-mv commented Jul 16, 2019 •
edited
Loading

  • sam init -r node -d npm now yeilds a sam template with nodejs10.x as
    runtime instead of nodejs

Issue #, if available:

#1251

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv
fix: default to nodejs10.x on init
ce192f4 
- `sam init -r node -d npm` now yeilds a sam template with `nodejs10.x` as
  runtime instead of `nodejs`
@sriram-mv sriram-mv requested a review from jfuss July 16, 2019 18:58
@sriram-mv sriram-mv changed the base branch from develop to candidate/release/20 July 29, 2019 22:57
@sriram-mv sriram-mv merged commit b128a58 into aws:candidate/release/20 Jul 30, 2019
@sriram-mv sriram-mv mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jfuss jfuss jfuss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sriram-mv @jfuss