warning: deprecation warning message - Python 2.7#1306
Merged
sriram-mv merged 2 commits intoaws:developfrom Aug 7, 2019
Merged
warning: deprecation warning message - Python 2.7#1306sriram-mv merged 2 commits intoaws:developfrom
sriram-mv merged 2 commits intoaws:developfrom
Conversation
sanathkr
approved these changes
Jul 30, 2019
sanathkr
suggested changes
Jul 30, 2019
Contributor
sanathkr
left a comment
There was a problem hiding this comment.
Actually.. does it make sense add this to main.py instead? Telemetry message is there. It will be good to centralize the prompt messages in one place.
Contributor
Author
|
Moving to main.py only prints the warning message on sub-commands eg: sam build, sam local invoke. and not on all commands. This way it prints it on all commands. even on |
Contributor
|
Makes sense. Thanks for the clarification |
12e8785 to
aaa0e4d
Compare
jfuss
approved these changes
Aug 6, 2019
- if AWS SAM CLI is installed under python2.7 environment, there is a warning which says that AWS SAM CLI will no longer be installable under python2.7 from October 1st 2019.
aaa0e4d to
83eec45
Compare
Contributor
Author
|
Just rebased it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warning which says that AWS SAM CLI will no longer be installable
under python2.7 from October 1st 2019.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.