Conversation
There was a problem hiding this comment.
why is the prompt prefixed with "my-application"?
There was a problem hiding this comment.
Maybe {{ cookiecutter.project_name }} might be better, but we dont know the full path on the client system.
There was a problem hiding this comment.
But love the explicit instruction to create the S3 Bucket!
There was a problem hiding this comment.
Because I was going off of a more generic version of this and missed this when updating. Will update it with {{ cookiecutter.project_name }}
sriram-mv
left a comment
There was a problem hiding this comment.
Nice refresh on the docs! 🔥
There was a problem hiding this comment.
Maybe {{ cookiecutter.project_name }} might be better, but we dont know the full path on the client system.
There was a problem hiding this comment.
But love the explicit instruction to create the S3 Bucket!
There was a problem hiding this comment.
fetch logs generated by your "deployed" Lambda function? Does that make sense?
There was a problem hiding this comment.
Sure. I think that addition makes sense.
There was a problem hiding this comment.
Does mentioning some specific SAR apps also make sense? helps the user to continue the journey to more complex apps.
a019f2f to
3a5fc84
Compare
|
Rebased with HEAD of develop, so appveyor should now pass. |
|
I would like to get the Node Readme updated first. Once this one is completed, I will translate this into all the other init (except depreciated runtimes that we need to remove). |
Issue #, if available:
N/A
Description of changes:
Refresh the READMEs. I wanted to get feedback on the NodeJS one before going further with others.
Main changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.