Update aws-sam-translator Dependency#1330
Merged
jfuss merged 6 commits intoaws:developfrom Aug 10, 2019
Merged
Conversation
The `make pr` command set is passing, so pending integration tests.
Contributor
Author
|
It does look like we need to add some new tests before merging this. |
We now test a number of models from the SAM repo in our functional tests.
Contributor
Author
|
This now also addresses #803 |
jfuss
reviewed
Aug 9, 2019
| template = sam_translator.translate(sam_template=self.sam_template, | ||
| parameter_values={}) | ||
| LOG.debug("Translated template is:\n%s", yaml_dump(template)) | ||
| print("Translated template is:\n%s", yaml_dump(template)) |
Used it for test debugging, not needed for launch.
…cli into sam-translate-13-update
jfuss
approved these changes
Aug 9, 2019
Contributor
Author
jfuss
approved these changes
Aug 9, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
make prcommand set is passing, so pending integration tests.Issue #, if available: Numerous.
Description of changes: Bump aws-sam-translator dependency.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.