Merged
Conversation
jfuss
reviewed
Aug 12, 2019
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Are there any additional integ tests that would improve the confidence in release this? Trying to see if we can level up here in any way.
jfuss
reviewed
Aug 12, 2019
| template_dict = SamTranslatorWrapper(template_dict).run_plugins() | ||
|
|
||
| template_dict = SamBaseProvider._resolve_parameters(template_dict, parameter_overrides) | ||
| template_dict = SamBaseProvider._resolve_parameters( |
Contributor
There was a problem hiding this comment.
Is this needed anymore since we have the full resolver now?
Contributor
|
Did you address this? #1261 (comment) Unless I am missing it, region will resolve to whatever the default is but not based on profile or region passed into the command. This will make resolving arns in Fn::Sub not complete. This is really important for things like Layers. |
Contributor
|
Great work to get this over the line @viksrivat! |
viksrivat
added a commit
to viksrivat/aws-sam-cli
that referenced
this pull request
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This is an update to the #1261 pr by integrating intrinsics into the translator.
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.