feat: Provide pinned requirements to allow for reproducible builds#1391
Merged
jfuss merged 3 commits intoaws:developfrom Sep 10, 2019
Merged
feat: Provide pinned requirements to allow for reproducible builds#1391jfuss merged 3 commits intoaws:developfrom
jfuss merged 3 commits intoaws:developfrom
Conversation
Contributor
|
Closing #1369 ,as this PR supersedes it. |
6 tasks
jfuss
force-pushed
the
support/isoloated-builds
branch
from
5ca92cd to
f48c1ac
Compare
Contributor
Author
|
|
sriram-mv
reviewed
Sep 6, 2019
| # Don't try and compare the isolated list with the Python2 version. SAM CLI installers | ||
| # all use Python3.6+ and Python2.7 is going EOL | ||
| if sys.version_info[0] < 3: | ||
| sys.exit(0) |
sriram-mv
approved these changes
Sep 6, 2019
| # full requirement==version is within the isolated list. | ||
| installed_pkg = installed_pkg_version.split("==")[0] | ||
| # There is a py library we use but due to how we are comparing requirements, we need to handle this as a special case. :( | ||
| if installed_pkg not in ("py", "boto3") and base_req.startswith(installed_pkg): |
Contributor
There was a problem hiding this comment.
Nit: can this be another file (list of ignored deps for fidelity checks)
Contributor
Author
There was a problem hiding this comment.
I am going to leave as a tuple instead of a file. This is a temporary solution to make sure builds going forward are deterministic. I want to move us into a tool that does the lockfile for us, which is way better than this script :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.