Require Cors header values to be specified with double quotes.#1395
Merged
sriram-mv merged 7 commits intoaws:developfrom Sep 11, 2019
Merged
Require Cors header values to be specified with double quotes.#1395sriram-mv merged 7 commits intoaws:developfrom
sriram-mv merged 7 commits intoaws:developfrom
Conversation
Contributor
|
Have re-kicked the build, somehow it didnt start, will review this once the builds are okay. |
sriram-mv
suggested changes
Sep 6, 2019
Contributor
sriram-mv
left a comment
sriram-mv
left a comment
There was a problem hiding this comment.
couple comments, otherwise this looks good. 👍
Contributor
|
@stalar Thanks for the PR. Things look good. I did add two additional unit tests to verify exceptions are thrown correctly. @thesriram Can you take a peek at this? I think its good to go but wanted another approval since I added some tests. |
|
Will the patch for this not be available until the next cli release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1381
Description of changes:
Require Cors header values to have double quoting for start-api. If quotes are missing, fail with an exception.
Verified by running the template from #1381 both locally and deployed.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.