fix(intrinsics): Attempt to resolve all intrinsics but leave untouched in failure#1410
Merged
sanathkr merged 1 commit intoaws:developfrom Sep 13, 2019
Merged
fix(intrinsics): Attempt to resolve all intrinsics but leave untouched in failure#1410sanathkr merged 1 commit intoaws:developfrom
sanathkr merged 1 commit intoaws:developfrom
Conversation
awood45
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1386 #1408 #1407
Description of changes:
I described the issue here: #1386 (comment)
Previously, when we encountered an intrinsic we could not resolve, the exception was thrown up to the resource level and we set the original resource into the modified (in memory) template we use for the commands. Instead, this change will only set that property back into the dictionary allowing any intrinsics we can resolve to remain resolved.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.