Skip to content

fix(intrinsics): Attempt to resolve all intrinsics but leave untouched in failure#1410

Merged
sanathkr merged 1 commit intoaws:developfrom
jfuss:fix/1386
Sep 13, 2019
Merged

fix(intrinsics): Attempt to resolve all intrinsics but leave untouched in failure#1410
sanathkr merged 1 commit intoaws:developfrom
jfuss:fix/1386

Conversation

@jfuss
Copy link
Contributor

@jfuss jfuss commented Sep 13, 2019

Issue #, if available:
#1386 #1408 #1407

Description of changes:
I described the issue here: #1386 (comment)

Previously, when we encountered an intrinsic we could not resolve, the exception was thrown up to the resource level and we set the original resource into the modified (in memory) template we use for the commands. Instead, this change will only set that property back into the dictionary allowing any intrinsics we can resolve to remain resolved.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants