Deprecate: Remove Python2.7 installation support #1416
Conversation
|
Nice 🔥🔥, next up all of the six stuff, six.moves etc. |
jfuss
changed the title
requirements/dev.txt
Outdated
| pytest==5.1.2 | ||
| #mock==2.0.0 # mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards. |
There was a problem hiding this comment.
Should we remove this completely?
There was a problem hiding this comment.
O yes this should be.
|
|
||
| class InvalidLayerVersionArn(UserException): | ||
| """ | ||
| The LayerVersion Arn given in the template is Invalid | ||
| """ | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class UnsupportedIntrinsic(UserException): |
There was a problem hiding this comment.
We dont need a pass anymore? Didnt know this. Good to know.
There was a problem hiding this comment.
| @@ -152,7 +154,7 @@ def _download_swagger(self, location): | |||
| """ | |||
|
|
|||
| if not location: | |||
| return | |||
There was a problem hiding this comment.
Are we just being explicit? or is this the norm with Python3?
There was a problem hiding this comment.
This falls under pylint's inconsistent-return-statements (R1710), see http://pylint.pycqa.org/en/latest/technical_reference/features.html for more details.
I ended up just updating everything to make this go away. We could instead ignore this and revert the commit with all these types of changes.
| else: | ||
| LOG.debug("Builder crashed") | ||
| raise ValueError(msg) | ||
| LOG.debug("Builder crashed") |
There was a problem hiding this comment.
Not blocking on this, but we have the same verbiage on the 'builder crashed' on if there was an exception or if there was error code we dont understand. We need to differentiate on that.
| @@ -1,3 +1,4 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Yes I removed that but forgot to commit it to see if windows would pass.
|
Also could you remove: https://github.com/awslabs/aws-sam-cli/blob/develop/samcli/cli/command.py#L27 as well :) |
Good call. |
sriram-mv
changed the title
This reverts commit 6e40c34af8e814d260eb3747ab11fecddad31032.
| byte_stdout = sys.stdout.buffer # pylint: disable=no-member | ||
|
|
||
| return byte_stdout | ||
| return sys.stdout.buffer |
This reverts commit 360d90a. This commit originally reverted aws#1140 due to os.symlink not being available on windows in Python2.7 stdlib, details here: aws#1315 (comment). We recently removed Python2.7 support in aws#1416, so this commit is a revert of the revert, with some additional black formating to make `make pr` pass.
Issue #, if available:
#1273
Description of changes:
Removes the ability to install SAM CLI into a Py2 environment.
I want to take this time to also upgrade some of our dev dependencies that were stuck in the stone age and get rid of six. We will need to do similar things in
aws_lambda_buildersbut that will be completely separate than this. If some of the dev dependency upgrades become to much, I will move that to a different PR but for now keeping this as a Draft PR.Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.