Skip to content

Fix Ruby Integ Test#1429

Merged
awood45 merged 1 commit intoaws:developfrom
awood45:ruby-integ-test-fix
Sep 25, 2019
Merged

Fix Ruby Integ Test#1429
awood45 merged 1 commit intoaws:developfrom
awood45:ruby-integ-test-fix

Conversation

@awood45
Copy link
Contributor

@awood45 awood45 commented Sep 24, 2019

The httparty gem has native extensions, and can fail to build on Windows, which is causing integ test failures. Changed to a new gem which should be much more platform-agnostic to build.

Issue #, if available:

Description of changes:

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The `httparty` gem has native extensions, and can fail to build on
Windows, which is causing integ test failures. Changed to a new gem
which should be much more platform-agnostic to build.
@awood45 awood45 requested a review from sriram-mv September 24, 2019 23:17
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! @awood45

@awood45 awood45 merged commit 4fcb030 into aws:develop Sep 25, 2019
@awood45 awood45 deleted the ruby-integ-test-fix branch September 25, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants