Skip to content

Conversation

@trenton
Copy link

@trenton trenton commented Oct 7, 2019

Description of changes:

Adds events for Lambda functions for SageMaker Ground Truth for these Lambda functions in the CreateLabelingJob operation:

  1. PreHumanTask
  2. AnnotationConsolidation

Checklist:

  • [n/a] Write Design Document (Do I need to write a design document?)
  • [n/a] Write unit tests
  • [n/a] Write/update functional tests
  • [n/a] Write/update integration tests
  • make pr passes
  • [n/a] Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds events for Lambda functions for:

1. PreHumanTask
2. AnnotationConsolidation
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions/comments. Overall this looks good.

"version": "2018-10-16",
"labelingJobArn": "arn:{{{partition}}}:sagemaker:{{{region}}}:{{{account_id}}}:labeling-job/{{{labeling_job_name}}}",
"dataObject" : {
"source-ref": "s3://{{{bucket}}}/{{{data_object_key}}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why split out bucket and data_object_key in this way? Might be easier for customers to provide the S3 uri directly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below

"labelAttributeName": "{{{label_attribute_name}}}",
"roleArn" : "aws:{{{partition}}}:iam::{{account_id}}:role/{{{execution_role}}}",
"payload": {
"s3Uri": "s3://{{{bucket}}}/{{{labeling_job_name}}}/annotations/worker_response/{{{iteration_object_timestamp}}}.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here: It could make it easier for customers to just provide the bucket/labeling_job_name as one parameter instead of 2. Thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll go back through and make the params match what's in CreateLabelingJob, since in some cases, the creator isn't specifying a s3 bucket, but rather a full s3 url.

@trenton
Copy link
Author

trenton commented Oct 27, 2019

I fixed the names in the generated event to match what what someone using the API would be passing.

Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. LGTM

@jfuss jfuss added stage/accepted Accepted and will be fixed and removed stage/in-review labels Oct 28, 2019
@awood45 awood45 merged commit 80532d9 into aws:develop Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stage/accepted Accepted and will be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants