Skip to content

Update aws-sam-translator Dependency#1448

Merged
sriram-mv merged 5 commits intoaws:developfrom
ShreyaGangishetty:sam-dependency-bump-branch97577
Oct 21, 2019
Merged

Update aws-sam-translator Dependency#1448
sriram-mv merged 5 commits intoaws:developfrom
ShreyaGangishetty:sam-dependency-bump-branch97577

Conversation

@ShreyaGangishetty
Copy link

@ShreyaGangishetty ShreyaGangishetty commented Oct 8, 2019

Issue #, if available:

Description of changes:
Bump sam-translator version to 1.15.1
make pr fails as it cannot find 1.15.1 version

Checklist:

  • pytest tests/functional/commands/validate/lib/test_sam_template_validator.py passes
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files with AWS::Serverless::Application types need to be removed. The AWS::Serverless::Applicaiton Resources require credentials in order for the Transform to work. For now, we have excluded these in the validation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ... I have removed them manually in the next commit. I have to update the script to remove these files automatically from next time

@jfuss jfuss mentioned this pull request Oct 8, 2019
1 task
@sriram-mv
Copy link
Contributor

Going to re-kick appveyor builds since #1465 is merged.

@sriram-mv sriram-mv force-pushed the sam-dependency-bump-branch97577 branch from 9e8fb91 to 2c01e01 Compare October 17, 2019 18:53
@sriram-mv
Copy link
Contributor

rebased on develop and pushed.

@sriram-mv sriram-mv force-pushed the sam-dependency-bump-branch97577 branch from fdbb09f to 5a6442f Compare October 17, 2019 22:24
@sriram-mv
Copy link
Contributor

rebased on develop and fixed conflicts.

@sriram-mv sriram-mv force-pushed the sam-dependency-bump-branch97577 branch from 5a6442f to d34d3e7 Compare October 18, 2019 21:49
@sriram-mv sriram-mv merged commit 0464b27 into aws:develop Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants