Update aws-sam-translator Dependency#1448
Merged
sriram-mv merged 5 commits intoaws:developfrom Oct 21, 2019
Merged
Conversation
jfuss
reviewed
Oct 8, 2019
Contributor
There was a problem hiding this comment.
Files with AWS::Serverless::Application types need to be removed. The AWS::Serverless::Applicaiton Resources require credentials in order for the Transform to work. For now, we have excluded these in the validation.
Author
There was a problem hiding this comment.
Yes ... I have removed them manually in the next commit. I have to update the script to remove these files automatically from next time
1 task
Contributor
|
Going to re-kick appveyor builds since #1465 is merged. |
9e8fb91 to
2c01e01
Compare
Contributor
|
rebased on develop and pushed. |
sanathkr
approved these changes
Oct 17, 2019
fdbb09f to
5a6442f
Compare
Contributor
|
rebased on develop and fixed conflicts. |
5a6442f to
d34d3e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bump sam-translator version to 1.15.1
make pr fails as it cannot find 1.15.1 version
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.