fix: Move validation of timeout is an int further down the stack#1515
Merged
sanathkr merged 3 commits intoaws:developfrom Nov 11, 2019
Merged
fix: Move validation of timeout is an int further down the stack#1515sanathkr merged 3 commits intoaws:developfrom
sanathkr merged 3 commits intoaws:developfrom
Conversation
sanathkr
reviewed
Nov 11, 2019
Contributor
There was a problem hiding this comment.
Few more examples to cover:
`3.2, "4.2", "0.123",
Contributor
Author
There was a problem hiding this comment.
Good callout. These end up not throwing due to the casting to int. I need to add an additional type/instance check before converting.
sanathkr
approved these changes
Nov 11, 2019
Contributor
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the change.
I want to make sure floats / strings-of-floats are covered. If they are, feel free to merge.
sanathkr
added
the
stage/waiting-for-release
jfuss
force-pushed
the
fix/build-failes-when-timeout-is-param
branch
from
fa02ab9 to
5e4a807
Compare
sanathkr
approved these changes
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.