chore: Simplify how timeouts are casted to an int#1518
Merged
jfuss merged 1 commit intoaws:developfrom Nov 12, 2019
Merged
Conversation
sanathkr
reviewed
Nov 11, 2019
| # Guard against float values like "3.2" | ||
| if not isinstance(self.timeout, int): | ||
| raise InvalidSamTemplateException("Invalid Number for Timeout: {}".format(self.timeout)) | ||
| self.timeout = int(self.timeout) |
Contributor
There was a problem hiding this comment.
How does this handle None / empty string?
Contributor
Author
There was a problem hiding this comment.
int(None) raises TypeError, int('') raises ValueError
jfuss
added
area/lambda-invoke
area/local/start-api
sanathkr
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.