fix: override botocore logging to a NullHandler #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
approved these changes
Nov 15, 2019
sanathkr
reviewed
Nov 15, 2019
samcli/cli/main.py
Outdated
Contributor
There was a problem hiding this comment.
Does this silence all logs, including debug logs?
Contributor
Author
There was a problem hiding this comment.
https://docs.python.org/3.6/howto/logging.html#configuring-logging-for-a-library explains it. Basically it will prevent the library’s logged event being output to sys.stderr and is documented as "A do-nothing handler". This is also what boto3 is doing but botocore is not (for whatever reason).
From reading the docs, my understanding is yes.
jfuss
force-pushed
the
fix/logging-from-botocore
branch
from
5849735 to
19920fb
Compare
sanathkr
approved these changes
Nov 15, 2019
sanathkr
force-pushed
the
fix/logging-from-botocore
branch
from
19920fb to
e071989
Compare
sriram-mv
pushed a commit
that referenced
this pull request
Nov 20, 2019
sriram-mv
pushed a commit
that referenced
this pull request
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.