chore: Support Java11, Python3.8, and Nodejs12.x runtimes#1549
chore: Support Java11, Python3.8, and Nodejs12.x runtimes#1549jfuss merged 31 commits intoaws:developfrom
Conversation
|
|
jfuss
force-pushed
the
support/new-runtimes
branch
from
9d531f3 to
4eafdc9
Compare
appveyor.yml
Outdated
| - sh: "/tmp/black --check setup.py tests samcli scripts" | ||
| - sh: "python scripts/check-isolated-needs-update.py" | ||
|
|
||
| # Set JAVEHOME to java11 |
| - sh: "python scripts/check-isolated-needs-update.py" | ||
|
|
||
| # Set JAVEHOME to java11 | ||
| - sh: "JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64" |
There was a problem hiding this comment.
JAVA_HOME for java8 is not set. I am not sure how appveyor works, but can this be an issue on next run, when JAVA_HOME will be for java11 and test would run expecting them to be 8?
There was a problem hiding this comment.
Nevermind, now that I think about it, it shouldn't be an issue since it'll be a new session.
There was a problem hiding this comment.
We set JAVA_HOME to java8 on line 82 (first step in the install step). The first pass of build tests will run with java8. I needed a way to also run the Java11 build tests. Instead of creating another appveyor project, I edit the JAVA_HOME env var to be java11 within the test_script phase of appveyor.
sriram-mv
left a comment
sriram-mv
left a comment
There was a problem hiding this comment.
do we need to anything for the debug entrypoints?
| - sh: "which python3.7" | ||
| - sh: "which python2.7" | ||
|
|
||
| - sh: "PATH=$PATH:/usr/bin/python3.8:/usr/bin/python3.7" |
There was a problem hiding this comment.
do 3.6 and 2.7 also need to be added to path?
There was a problem hiding this comment.
2.7 and 3.6 are already there: https://www.appveyor.com/docs/linux-images-software/#python
I am considering moving off of the pre-installed everything in favor how installing python versions through apt-get. This will make things a little more consistent in appveyor, but didn't want to go that deep here.
| INIT_RUNTIMES = [ | ||
| "nodejs10.x", | ||
| "python3.7", | ||
| # latest of each runtime version |
There was a problem hiding this comment.
I think this list is what is used to showcases the runtimes during init, we should make this ordered, with a set maybe.
There was a problem hiding this comment.
This is ordered just in a list. I can update it to a set but there isn't a whole difference here (other than duplicate entry guard).
This is used within interactive init not in the help text.
|
@thesriram I added debug support for Python3.8 and Node12.x, which are based on the previous runtimes. Java11 needs more investment before we can confidently support debugging. The reason for this is because Java11 containers are based on provided and the overriding mechanism is slightly different. I don't want to hold up releasing everything else so my recommendation is to go forward without debug support. In the meantime, I will be spending time on ensuring things work before adding that related debug config. |
4 participants
Issue #, if available:
Description of changes:
What is left to do:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.