Skip to content

fix: stack outputs on deploy #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriram-mv merged 1 commit into from
Nov 20, 2019
Merged

fix: stack outputs on deploy #1556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions samcli/lib/deploy/deployer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,8 @@

DESCRIBE_CHANGESET_TABLE_HEADER_NAME = "CloudFormation stack changeset"

OUTPUTS_FORMAT_STRING = "{OutputKey:<{0}} {OutputValue:<{1}} {Description:<{2}}"
OUTPUTS_DEFAULTS_ARGS = OrderedDict(
{"OutputKey": "OutputKey", "OutputValue": "OutputValue", "Description": "Description"}
)
OUTPUTS_FORMAT_STRING = "{OutputKey-Description:<{0}} {OutputValue:<{1}}"
OUTPUTS_DEFAULTS_ARGS = OrderedDict({"OutputKey-Description": "OutputKey-Description", "OutputValue": "OutputValue"})


class Deployer:
Expand Down Expand Up @@ -406,7 +404,7 @@ def create_and_wait_for_changeset(
def _stack_outputs(self, stack_outputs, **kwargs):
for output in stack_outputs:
pprint_columns(
columns=[output["OutputKey"], output["OutputValue"], output.get("Description", "-")],
columns=[" - ".join([output["OutputKey"], output.get("Description", "")]), output["OutputValue"]],
width=kwargs["width"],
margin=kwargs["margin"],
format_string=OUTPUTS_FORMAT_STRING,
Expand Down