fix: parameter override prompts during guided deploy#1558
Merged
sriram-mv merged 2 commits intoaws:release-v0.32.0from Nov 20, 2019
Merged
fix: parameter override prompts during guided deploy#1558sriram-mv merged 2 commits intoaws:release-v0.32.0from
sriram-mv merged 2 commits intoaws:release-v0.32.0from
Conversation
sriram-mv
commented
Nov 20, 2019
| _params = [] | ||
| for key, value in parameter_overrides.items(): | ||
| if isinstance(value, dict): | ||
| if not value.get("Hidden"): |
Contributor
Author
There was a problem hiding this comment.
We do not write to file if the param is hidden
awood45
approved these changes
Nov 20, 2019
sriram-mv
added a commit
that referenced
this pull request
Nov 23, 2019
* fix: parameter override prompts during guided deploy * tests: unit tests for not saving secure params during guided deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dont save noecho params to config file via guided deploy
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.