Add Exception Handling for Client Misconfiguration #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
suggested changes
Nov 20, 2019
samcli/lib/bootstrap/bootstrap.py
Outdated
| session = boto3.Session(profile_name=profile if profile else None) | ||
| cloudformation_client = session.client("cloudformation", config=Config(region_name=region if region else None)) | ||
| except NoCredentialsError: | ||
| raise UserException( |
Contributor
There was a problem hiding this comment.
we need to change userexception to a more specific exception.
merge after adding unit tests
Remaining work is to add tests for this case.
sriram-mv
pushed a commit
that referenced
this pull request
Nov 23, 2019
* Add Exception Handling for Client Misconfiguration * Import Botocore Exceptions * Change Client Exception Heirarchy Remaining work is to add tests for this case. * Add Unit Test for Bootstrap Client Failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.