bugfixes: stack-name is required on deploy
#1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- providing non standard capabilities gives an appropriate error message - add s3 prefix to be the stack name during guided deploy
c2tarun
reviewed
Nov 21, 2019
Comment on lines
+138
to
+139
| - | ||
| !Ref SamCliSourceBucket |
Contributor
There was a problem hiding this comment.
this looks bit weird, should this be - !Ref SamCliSourceBucket?
Contributor
There was a problem hiding this comment.
I think it could also be !Sub "arn:aws:s3:::${SamCliSourceBucket}"
samcli/commands/_utils/options.py
Outdated
| :return: | ||
| """ | ||
|
|
||
| default_stack_name = "sam-app" |
Contributor
There was a problem hiding this comment.
nit-pick: I am not sure if this is a convention we are following but at few places I have seen constants to be in all CAPS like: DEFAULT_STACK_NAME.
awood45
suggested changes
Nov 22, 2019
| "--stack-name", | ||
| required=True, | ||
| required=False, | ||
| callback=guided_deploy_stack_name, |
Contributor
There was a problem hiding this comment.
Nice! Should roll this into init too sometime, possibly.
Comment on lines
+138
to
+139
| - | ||
| !Ref SamCliSourceBucket |
Contributor
There was a problem hiding this comment.
I think it could also be !Sub "arn:aws:s3:::${SamCliSourceBucket}"
awood45
approved these changes
Nov 22, 2019
sriram-mv
added a commit
that referenced
this pull request
Nov 23, 2019
* bugfixes: `stack-name` is required on deploy - providing non standard capabilities gives an appropriate error message - add s3 prefix to be the stack name during guided deploy * fix: help text on parameter overrides * fix: add `serverlessrepo` access to managed stack * fix: address comments * fix: usability fixes * fix: parameter defaults are casted to string * fix: unit tests on bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.