Skip to content

integ tests: throttling with cloudformation #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanathkr merged 1 commit into from
Nov 23, 2019
Merged

integ tests: throttling with cloudformation #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/integration/deploy/test_deploy_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import tempfile
import uuid
import time
from subprocess import Popen, PIPE
from unittest import skipIf

Expand All @@ -16,6 +17,7 @@
# Deploy tests require credentials and CI/CD will only add credentials to the env if the PR is from the same repo.
# This is to restrict package tests to run outside of CI/CD and when the branch is not master.
SKIP_DEPLOY_TESTS = RUNNING_ON_CI and RUNNING_TEST_FOR_MASTER_ON_CI
CFN_SLEEP = 3
Copy link
Contributor

@jfuss jfuss Nov 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3s enough?



@skipIf(SKIP_DEPLOY_TESTS, "Skip deploy tests in CI/CD only")
Expand All @@ -24,6 +26,7 @@ def setUp(self):
self.cf_client = boto3.client("cloudformation")
self.sns_arn = os.environ.get("AWS_SNS")
self.stack_names = []
time.sleep(CFN_SLEEP)
super(TestDeploy, self).setUp()

def tearDown(self):
Expand Down
4 changes: 3 additions & 1 deletion tests/regression/deploy/test_deploy_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import tempfile
import uuid
import time
from subprocess import Popen, PIPE
from unittest import skipIf

Expand All @@ -14,7 +15,7 @@
# Package Regression tests require credentials and CI/CD will only add credentials to the env if the PR is from the same repo.
# This is to restrict package tests to run outside of CI/CD and when the branch is not master.
SKIP_DEPLOY_REGRESSION_TESTS = RUNNING_ON_CI and RUNNING_TEST_FOR_MASTER_ON_CI

CFN_SLEEP = 3
# Only testing return codes to be equivalent


Expand All @@ -25,6 +26,7 @@ def setUp(self):
self.kms_key = os.environ.get("AWS_KMS_KEY")
self.stack_names = []
self.cf_client = boto3.client("cloudformation")
time.sleep(CFN_SLEEP)
super(TestDeployRegression, self).setUp()

def tearDown(self):
Expand Down