fix: move tests to a static bucket solution
#1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- s3 bucket is created is appropriate permissions and exposed via environment variable. - serverlessrepo.amazonaws.com has access to the static s3 bucket.
jfuss
reviewed
Nov 23, 2019
| cls.kms_key = os.environ.get("AWS_KMS_KEY") | ||
| # Use a pre-created S3 Bucket | ||
| cls.s3_bucket = s3.Bucket(cls.bucket_name) | ||
| cls.s3_bucket.create() |
Contributor
There was a problem hiding this comment.
Do we want to still do this as a fallback if AWS_S3 is not set? Thinking it is good for local where devs do not need to have additional things preconfigured
Contributor
Author
There was a problem hiding this comment.
OK, valid concern.
jfuss
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
environment variable.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.