Enabling local invoke debug mode for java8 and all nodejs runtimes #2

fmmirel · 2017-08-05T15:45:00Z

Add new --debug-port|-d flag to the "local invoke" command.
When specified, lambda containers will start in suspended debug mode exposing this port on the localhost.
At this moment, this only works for java8 and all nodejs runtimes.

sanathkr · 2017-08-05T18:23:35Z

runtime.go

where do these options come from? Can you link to a reference?

Sure: http://javahowto.blogspot.com/2010/09/java-agentlibjdwp-for-attaching.html

Cool, how about the other values like heapsize, GC etc?

Oh, I thought you meant the debug options. There's a comment about where I got these values immediately after the switch statement:

// configs from: https://github.com/lambci/docker-lambda

// to which we add the extra debug mode options

If you go to that repository you can inspect all of the default lambda container Dockerfiles. For example: https://github.com/lambci/docker-lambda/blob/master/nodejs/run/Dockerfile

sanathkr · 2017-08-05T18:25:11Z

start.go

Can we add debugging to this as well? We should keep behavior consistent between invoke and start-api

The reason why I didn't add this is the fact that adding the debug flag to start-api will map multiple functions to the same debug port in contrast to invoke, where each function is mapped to its own debug port. That might be fine if the intention is to handle the requests sequentially when debugging (i.e. not have multiple suspended lambda debug containers behind the same start-api server) Debugging one lambda function at a time seems reasonable enough to me but I'd like to get your input on this. EDIT: I went ahead and added support for this since it's low hanging fruit).

If the intention is to handle the requests in parallel, then we need to ask the user for a function:debugPort map. Adding this to the CLI input flags might be a bit messy. The ideal setup would be if the debug port could be grabbed from the actual SAM template, for each function (like the timeout), but this is not the case at the moment.

This makes sense. We should make a note of it in the documentation (README.md)

sanathkr · 2017-08-05T18:31:31Z

@fmmirel Thanks for doing these changes. This is one of the most useful features of the CLI!

fmmirel · 2017-08-05T19:26:26Z

@sanathkr Thank you for having a look at the changes! EDIT: I've added the debug mode flag to the start-api method as requested.

sanathkr · 2017-08-06T18:54:51Z

runtime.go

This will kill the CLI process. What happens to the docker container? You should cleanup right?

The docker container does get removed. r.Cleanup() is called before os.Exit(0) and it takes care of the cleanup process.

Ah, okay. I missed it. Thanks

sanathkr · 2017-08-06T18:58:44Z

Can you also update the README to include a section about debugging?

fmmirel · 2017-08-06T19:52:31Z

Sure. I'll post an update to the pull request tomorrow morning. EDIT: I added the debug information to the readme file.

PaulMaddox

LGTM - one small comment

PaulMaddox · 2017-08-06T09:29:42Z

runtime.go

What's the benefit of having this as an anon struct (and map), rather than just the map that was there before?

Hi Paul. Thank you for having a look!

The reason why I altered the previous setup is the fact that I need to use the runtime names in the switch I added in the "getDebugEntrypoint" method. Previously, the runtime names were just keys in a map so they could not be used as const values to compare against.

Run httpapi locally

Run httpapi locally sam integ test

feat: build strategy

* # This is a combination of 2 commits. # This is the 1st commit message: Add dotnet7 build method for provided * Added 'BuildMethod: dotnet7' using 'Runtime:provided' * 'Runtime:provided' is only for the provided runtime and not the dotnet runtime Testing with sample SAM template: ( See BuildMethod and Runtime below ) ... HelloWorldFunction: Type: AWS::Serverless::Function Metadata: BuildMethod: dotnet7 Properties: CodeUri: ./src/HelloWorld/ Handler: HelloWorld::HelloWorld.Function::FunctionHandler Runtime: provided Architectures: - x86_64 ... # This is the commit message #2: Add dotnet7 build method for provided * Added 'BuildMethod: dotnet7' using 'Runtime:provided' * 'Runtime:provided' is only for the provided runtime and not the dotnet runtime Testing with sample SAM template: ( See BuildMethod and Runtime below ) ... HelloWorldFunction: Type: AWS::Serverless::Function Metadata: BuildMethod: dotnet7 Properties: CodeUri: ./src/HelloWorld/ Handler: HelloWorld::HelloWorld.Function::FunctionHandler Runtime: provided Architectures: - x86_64 ... * run black reformat Co-authored-by: Samiullah Mohammed <samiull@amazon.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>

* feat: add dotnet7 build method (#428) * # This is a combination of 2 commits. # This is the 1st commit message: Add dotnet7 build method for provided * Added 'BuildMethod: dotnet7' using 'Runtime:provided' * 'Runtime:provided' is only for the provided runtime and not the dotnet runtime Testing with sample SAM template: ( See BuildMethod and Runtime below ) ... HelloWorldFunction: Type: AWS::Serverless::Function Metadata: BuildMethod: dotnet7 Properties: CodeUri: ./src/HelloWorld/ Handler: HelloWorld::HelloWorld.Function::FunctionHandler Runtime: provided Architectures: - x86_64 ... # This is the commit message #2: Add dotnet7 build method for provided * Added 'BuildMethod: dotnet7' using 'Runtime:provided' * 'Runtime:provided' is only for the provided runtime and not the dotnet runtime Testing with sample SAM template: ( See BuildMethod and Runtime below ) ... HelloWorldFunction: Type: AWS::Serverless::Function Metadata: BuildMethod: dotnet7 Properties: CodeUri: ./src/HelloWorld/ Handler: HelloWorld::HelloWorld.Function::FunctionHandler Runtime: provided Architectures: - x86_64 ... * run black reformat Co-authored-by: Samiullah Mohammed <samiull@amazon.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> * update provided with provided.al2 * Update test_build_cmd.py * Update test_workflow_config.py * Update aws-lambda-tools-defaults.json Co-authored-by: Beau Gosse <bgosse@amazon.com> Co-authored-by: Samiullah Mohammed <samiull@amazon.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>

fmmirel requested a review from PaulMaddox August 5, 2017 15:51

fmmirel changed the title ~~Enabling local invoke debug mode for java and all nodejs runtimes~~ Enabling local invoke debug mode for java8 and all nodejs runtimes Aug 5, 2017

fmmirel self-assigned this Aug 5, 2017

fmmirel requested review from sergiu-terman and removed request for sergiu-terman August 5, 2017 16:10

sanathkr suggested changes Aug 5, 2017

View reviewed changes

sanathkr reviewed Aug 6, 2017

View reviewed changes

Mirel Ferchezau added 3 commits August 7, 2017 09:52

Enabling local invoke debug mode for java and all nodejs runtimes

d0c0bbe

Enabling local start-api debug mode

67c74d9

Add debug information to the readme

d15bf02

fmmirel force-pushed the dev-debug branch from d2c200f to d15bf02 Compare August 7, 2017 07:38

PaulMaddox suggested changes Aug 7, 2017

View reviewed changes

PaulMaddox approved these changes Aug 7, 2017

View reviewed changes

fmmirel merged commit b86245b into master Aug 7, 2017

fmmirel deleted the dev-debug branch August 7, 2017 08:32

jfuss mentioned this pull request Nov 14, 2018

Implementation of "sam build" CLI command #766

Merged

shane-js mentioned this pull request May 18, 2020

Feature Request: API Gateway Authorizer support in SAM Local #137

Closed

moelasmar referenced this pull request in moelasmar/aws-sam-cli Oct 23, 2020

Merge pull request #2 from pyk/run-httpapi-locally

51884ac

Run httpapi locally

wchengru referenced this pull request in wchengru/aws-sam-cli Oct 24, 2020

Merge pull request #2 from wchengru/run-httpapi-locally-sam-integ-test

a1cc227

Run httpapi locally sam integ test

mndeveci referenced this pull request in mndeveci/aws-sam-cli Oct 27, 2020

Merge pull request #2 from mndeveci/mingkun_build_strategy

bd89918

feat: build strategy

ozbillwang mentioned this pull request Feb 2, 2021

SAM deploy doesn't set environment variables #1163

Closed

mndeveci referenced this pull request in mndeveci/aws-sam-cli Nov 23, 2021

use region if it is possible #2

90cea58

ghost mentioned this pull request Dec 5, 2021

No response from invoke container for Lambda inside docker-compose #2837

Open

e88z4 mentioned this pull request Aug 23, 2023

SAM Accelerate fails to resolve dependencies during build #4054

Open

licjun mentioned this pull request Nov 20, 2025

Fix integration test failures for multi-tenancy #8447

Merged

Enabling local invoke debug mode for java8 and all nodejs runtimes #2

Enabling local invoke debug mode for java8 and all nodejs runtimes #2

Uh oh!

Conversation

fmmirel commented Aug 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmmirel Aug 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmmirel Aug 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanathkr commented Aug 5, 2017

Uh oh!

fmmirel commented Aug 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmmirel Aug 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanathkr commented Aug 6, 2017

Uh oh!

fmmirel commented Aug 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaulMaddox left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmmirel Aug 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fmmirel Aug 5, 2017 •

edited

Loading

fmmirel Aug 5, 2017 •

edited

Loading

fmmirel commented Aug 5, 2017 •

edited

Loading

fmmirel Aug 6, 2017 •

edited

Loading

fmmirel commented Aug 6, 2017 •

edited

Loading

fmmirel Aug 7, 2017 •

edited

Loading