Skip to content

Conversation

@aahung
Copy link
Contributor

@aahung aahung commented Nov 18, 2020

Which issue(s) does this change fix?

Why is this change necessary?

When AppVeyor updates their python env, like from 3.7.7 to 3.7.9, 3.7.7 won't be available, and builds will fail due to the error:

/opt/appveyor/build-agent/bash-shell.sh: line 51: /home/appveyor/venv3.7.7/bin/activate: No such file or directory

According to AppVeyor doc, we don't have to specify patch version: https://www.appveyor.com/docs/linux-images-software/#python

image

How does it address the issue?

Remove patch version so it can handle patch version python upgrade on AppVeyor side.

What side effects does this change have?

nothing

Checklist

  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung requested a review from a team November 18, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants