Add support for CloudFormation ModuleVersion and ResourceVersion uploads#2667
Merged
moelasmar merged 2 commits intoaws:developfrom Mar 25, 2021
benbridts:cloudformation-types
Merged
Add support for CloudFormation ModuleVersion and ResourceVersion uploads#2667moelasmar merged 2 commits intoaws:developfrom benbridts:cloudformation-types
moelasmar merged 2 commits intoaws:developfrom
benbridts:cloudformation-types
Conversation
moelasmar
approved these changes
Mar 25, 2021
CoshUS
approved these changes
Mar 25, 2021
elbayaaa
pushed a commit
to elbayaaa/aws-sam-cli
that referenced
this pull request
Mar 25, 2021
…ads (aws#2667) Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
The recently released CloudFormation ModuleVersion and ResourceVersion need a package on S3.
How does it address the issue?
It adds support to specify a local path to the right zip file in the template.
Remarks
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.