fix: sam build fails when layer logicalID shared across stacks#2760
Merged
aahung merged 4 commits intoaws:developfrom Mar 24, 2021
Merged
fix: sam build fails when layer logicalID shared across stacks#2760aahung merged 4 commits intoaws:developfrom
aahung merged 4 commits intoaws:developfrom
Conversation
10 tasks
7023b5b to
88d3991
Compare
88d3991 to
0bb730b
Compare
8 tasks
hoffa
approved these changes
Mar 23, 2021
CoshUS
approved these changes
Mar 23, 2021
aahung
commented
Mar 24, 2021
Comment on lines
148
to
149
| if not isinstance(arn, str): | ||
| raise UnsupportedIntrinsic("{} is an Unsupported Intrinsic".format(arn)) |
Contributor
Author
There was a problem hiding this comment.
this was originally here, just reverting
Contributor
Author
|
just discussed with @mndeveci, for the change that prevents local invoking a function containing unresolvable layer, the risk is unknown and the benefit does not justify the risk. I just reverted that part and use a |
mndeveci
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
fix #2724
Why is this change necessary?
sam-cli does not support resolving intrinsic functions in parameters/outputs, which results in incorrect layer reference when the layer is passed from some other stacks using intrinsic functions.
Before we have a great support of intrinsic functions, customers should still be able to build their stacks. Incorrect resolution of layers should only affect
local *.How does it address the issue?
Delay the validation process and only raise exception when certain layer properties are used.
I added two integration tests to cover both using parameters (pass down) and outputs (pass up).
*pass up: template-pass-up.yaml, pass down: template-pass-down.yaml
sam buildworks,sam local invokeworkssam buildworks,sam local invoke:worksError: {'Fn::GetAtt': ['ChildApp', 'Outputs.LayerVersion']} is an Unsupported Intrinsicsam buildfailed withinvalid layer arnerrorsam local invokefailed withinvalid layer arnerrorsam buildworkssam local invokefailed withinvalid layer arnerrorWhat side effects does this change have?
for the "pass up" case, customers won't be able to local invoke anymore. This should be the expected behavior.Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.