Revert "feat: add option --container-host to commands local start-api, local start-lambda and local invoke (#2700)"#2794
Merged
qingchm merged 1 commit intoaws:developfrom Apr 6, 2021
xazhao:revert-container-host
Merged
Revert "feat: add option --container-host to commands local start-api, local start-lambda and local invoke (#2700)"#2794qingchm merged 1 commit intoaws:developfrom xazhao:revert-container-host
qingchm merged 1 commit intoaws:developfrom
xazhao:revert-container-host
Conversation
qingchm
approved these changes
Apr 6, 2021
hoffa
approved these changes
Apr 6, 2021
|
Are there any details on why this was reverted or if its being looked at again? |
Contributor
|
It's being worked on; we decided to iron out some issues with port binding and warm containers before release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e653fe2.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.