Skip to content

Revert "feat: add option --container-host to commands local start-api, local start-lambda and local invoke (#2700)"#2794

Merged
qingchm merged 1 commit intoaws:developfrom
xazhao:revert-container-host
Apr 6, 2021
Merged

Revert "feat: add option --container-host to commands local start-api, local start-lambda and local invoke (#2700)"#2794
qingchm merged 1 commit intoaws:developfrom
xazhao:revert-container-host

Conversation

@xazhao
Copy link
Contributor

@xazhao xazhao commented Apr 6, 2021

This reverts commit e653fe2.

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…, local start-lambda and local invoke (#2700)"

This reverts commit e653fe2.
@hoffa hoffa changed the title Revert "feat: add option --container-host to commands local start-api… Revert "feat: add option --container-host to commands local start-api, local start-lambda and local invoke (#2700)" Apr 6, 2021
@qingchm qingchm merged commit 8c1cbfc into aws:develop Apr 6, 2021
@clicktravel-robin
Copy link

Are there any details on why this was reverted or if its being looked at again?

@hoffa
Copy link
Contributor

hoffa commented Apr 7, 2021

It's being worked on; we decided to iron out some issues with port binding and warm containers before release.

moelasmar pushed a commit to moelasmar/aws-sam-cli that referenced this pull request Jul 1, 2021
…, local start-lambda and local invoke (aws#2700)" (aws#2794)

This reverts commit e653fe2.

Co-authored-by: Xia Zhao <xazhao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants