feat(Auto ECR): Added Option to Auto Create ECR Repos During Deployment#2815
Merged
CoshUS merged 83 commits intoaws:developfrom Aug 20, 2021
Merged
feat(Auto ECR): Added Option to Auto Create ECR Repos During Deployment#2815CoshUS merged 83 commits intoaws:developfrom
CoshUS merged 83 commits intoaws:developfrom
Conversation
hoffa
reviewed
Apr 16, 2021
samcli/lib/bootstrap/companion_stack/companion_stack_builder.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Rehn <crehn@outlook.com>
mgrandis
reviewed
Jul 30, 2021
Contributor
mgrandis
left a comment
mgrandis
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor changes
| return stack["Outputs"] | ||
| except ClientError: | ||
| click.echo("\n\tLooking for resources needed for deployment: Not found.") | ||
| pass |
Contributor
There was a problem hiding this comment.
We should maybe have a log.debug here as well.
samcli/lib/bootstrap/companion_stack/companion_stack_manager.py
Outdated
Show resolved
Hide resolved
samcli/lib/bootstrap/companion_stack/companion_stack_manager.py
Outdated
Show resolved
Hide resolved
samcli/lib/bootstrap/companion_stack/companion_stack_manager.py
Outdated
Show resolved
Hide resolved
mgrandis
reviewed
Jul 30, 2021
Contributor
mgrandis
left a comment
mgrandis
left a comment
There was a problem hiding this comment.
Just 2 more minor changes
samcli/lib/bootstrap/companion_stack/companion_stack_manager.py
Outdated
Show resolved
Hide resolved
mgrandis
approved these changes
Jul 30, 2021
moelasmar
reviewed
Aug 10, 2021
moelasmar
approved these changes
Aug 10, 2021
sriram-mv
reviewed
Sep 7, 2021
| "AWSTemplateFormatVersion": "2010-09-09", | ||
| "Transform": "AWS::Serverless-2016-10-31", | ||
| "Description": "Managed Stack for AWS SAM CLI", | ||
| "Metadata": { |
Contributor
There was a problem hiding this comment.
Should we add the metadata ourselves in code, and move this entire template to its own file. We can then run cfn-lint as part of CI process on this template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
Added options to auto create ECR repos when deploying.
RFC: #2675
Also fixes Windows ANSI output during image pushes.
samcli/lib/package/stream_cursor_utils.pyWhat side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.