Skip to content

fix: Fix crash when nested CFN stack has dict TemplateURL (unresolved intrinsics) #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aahung merged 3 commits into from
May 19, 2021
Merged

fix: Fix crash when nested CFN stack has dict TemplateURL (unresolved intrinsics) #2879

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e91cd88
fix: Fix crash when nested CFN stack has dict TemplateURL
aahung May 12, 2021
9cef245
Add comments
aahung May 13, 2021
429942f
Merge branch 'develop' into fix-cfn-template-url-is-dict
aahung May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion samcli/lib/providers/sam_stack_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,14 @@ def _convert_cfn_stack_resource(
resource_properties: Dict,
global_parameter_overrides: Optional[Dict] = None,
) -> Optional[Stack]:
template_url = resource_properties.get("TemplateURL", "")
template_url = resource_properties.get("TemplateURL")

if isinstance(template_url, dict):
# This happens when TemplateURL has unresolvable intrinsic functions
# and it usually happens in CDK generated template files (#2832).
Copy link
Contributor

@hawflau hawflau May 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we can show a message to tell customers to try sam-beta-cdk (link).

Copy link
Contributor Author

@aahung aahung May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that solve this problem?

raise RemoteStackLocationNotSupported()

template_url = cast(str, template_url)
if SamLocalStackProvider.is_remote_url(template_url):
raise RemoteStackLocationNotSupported()
if template_url.startswith("file://"):
Expand Down