Skip to content

Adding AWS_ prefix to displayed out. #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c2tarun merged 1 commit into from
Jun 29, 2021
Merged

Adding AWS_ prefix to displayed out. #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samcli/lib/pipeline/bootstrap/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ def print_resources_summary(self) -> None:
"make sure to periodically rotate it:",
)
)
click.secho(self.color.green(f"\tACCESS_KEY_ID: {self.pipeline_user.access_key_id}"))
click.secho(self.color.green(f"\tSECRET_ACCESS_KEY: {self.pipeline_user.secret_access_key}"))
click.secho(self.color.green(f"\tAWS_ACCESS_KEY_ID: {self.pipeline_user.access_key_id}"))
click.secho(self.color.green(f"\tAWS_SECRET_ACCESS_KEY: {self.pipeline_user.secret_access_key}"))

def _get_stack_name(self) -> str:
sanitized_environment_name: str = re.sub("[^0-9a-zA-Z]+", "-", self.name)
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/lib/pipeline/bootstrap/test_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,14 +351,14 @@ def test_print_resources_summary_prints_the_credentials_of_the_pipeline_user_iff
name=ANY_ENVIRONMENT_NAME, pipeline_user_arn=ANY_PIPELINE_USER_ARN
)
environment_with_provided_pipeline_user.print_resources_summary()
self.assert_summary_does_not_have_a_message_like("ACCESS_KEY_ID", click_mock.secho)
self.assert_summary_does_not_have_a_message_like("SECRET_ACCESS_KEY", click_mock.secho)
self.assert_summary_does_not_have_a_message_like("AWS_ACCESS_KEY_ID", click_mock.secho)
self.assert_summary_does_not_have_a_message_like("AWS_SECRET_ACCESS_KEY", click_mock.secho)
click_mock.secho.reset_mock()

environment_without_provided_pipeline_user: Environment = Environment(name=ANY_ENVIRONMENT_NAME)
environment_without_provided_pipeline_user.print_resources_summary()
self.assert_summary_has_a_message_like("ACCESS_KEY_ID", click_mock.secho)
self.assert_summary_has_a_message_like("SECRET_ACCESS_KEY", click_mock.secho)
self.assert_summary_has_a_message_like("AWS_ACCESS_KEY_ID", click_mock.secho)
self.assert_summary_has_a_message_like("AWS_SECRET_ACCESS_KEY", click_mock.secho)

def assert_summary_has_a_message_like(self, msg, click_secho_mock):
self.assertTrue(
Expand Down