Merged
Conversation
8 tasks
SimonCMoore
approved these changes
Dec 1, 2021
hoffa
approved these changes
Dec 1, 2021
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Dec 15, 2021
… S3 URL (cn) (aws#3001) Co-authored-by: SimonCMoore <simon.moore@ndirect.co.uk>
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
… S3 URL (cn) (aws#3001) Co-authored-by: SimonCMoore <simon.moore@ndirect.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #2785
Which issue(s) does this change fix?
Why is this change necessary?
#2785 (comment)
How does it address the issue?
Add amazonaws.com.cn to the regex: the domain is found at https://docs.amazonaws.cn/en_us/aws/latest/userguide/endpoints-arns.html
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.