Skip to content

WIP: fix: Skip image-repository validation for ECR images (#2934)#3012

Closed
alexisfacques wants to merge 0 commit intoaws:developfrom
alexisfacques:fix/skip-validation-for-ecr-images
Closed

WIP: fix: Skip image-repository validation for ECR images (#2934)#3012
alexisfacques wants to merge 0 commit intoaws:developfrom
alexisfacques:fix/skip-validation-for-ecr-images

Conversation

@alexisfacques
Copy link
Contributor

Which issue(s) does this change fix?

Issue #2934

Why is this change necessary?

How does it address the issue?

  • Instead of resolving packageable Image functions from the raw template file(s) (get_template_function_resource_ids, get_template_artifacts_format), use the SamFunctionProvider to do so.

What side effects does this change have?

  • image_repository_validation occurs later on in the deploy process (requires the CLI context);
  • Renders get_template_function_resource_ids, get_template_artifacts_format obsolete (not yet deleted from the repo);
  • Reworked the SamFunctionProvider recent changes to make the resource selection a little bit more straightforward.

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alexisfacques alexisfacques force-pushed the fix/skip-validation-for-ecr-images branch from d8d4c0a to 80f62df Compare July 1, 2021 13:05
@alexisfacques alexisfacques changed the title fix: Skip image-repository validation for ECR images (#2934) WIP: fix: Skip image-repository validation for ECR images (#2934) Jul 1, 2021
@alexisfacques alexisfacques force-pushed the fix/skip-validation-for-ecr-images branch from 80f62df to cc806a2 Compare July 2, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant