WIP: fix: Skip image-repository validation for ECR images (#2934)#3012
Closed
alexisfacques wants to merge 0 commit intoaws:developfrom
Closed
WIP: fix: Skip image-repository validation for ECR images (#2934)#3012alexisfacques wants to merge 0 commit intoaws:developfrom
alexisfacques wants to merge 0 commit intoaws:developfrom
Conversation
d8d4c0a to
80f62df
Compare
80f62df to
cc806a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Issue #2934
Why is this change necessary?
image_repository_validationfor Docker-packaged lambda functions with valid ECR locations (Issue Skip Docker Lambda image builds when ImageUri is a valid ECR location #2934, introduced in PR fix: Skip build of Docker image if ImageUri is a valid ECR URL (#2934) #2935);--guidedguided context prompts.How does it address the issue?
get_template_function_resource_ids,get_template_artifacts_format), use theSamFunctionProviderto do so.What side effects does this change have?
image_repository_validationoccurs later on in the deploy process (requires the CLI context);get_template_function_resource_ids,get_template_artifacts_formatobsolete (not yet deleted from the repo);SamFunctionProviderrecent changes to make the resource selection a little bit more straightforward.Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.