fix: Skip image-repository validation of ECR images (#2934)#3015
Closed
alexisfacques wants to merge 4 commits intoaws:developfrom
Closed
fix: Skip image-repository validation of ECR images (#2934)#3015alexisfacques wants to merge 4 commits intoaws:developfrom
alexisfacques wants to merge 4 commits intoaws:developfrom
Conversation
* fix lambda ECR image build/validation/deploy: - change guided context to only prompt image-repository option for buildable, packageable lambda images; - change CLI 'image-repository' 'image-repositories' option validation to only check the template for buildable, packageable lambda images.
Contributor
|
In order for this to be properly reviewed please resolve the merge conflicts and make sure that make pr passes! |
qingchm
suggested changes
Jun 17, 2022
Contributor
qingchm
left a comment
qingchm
left a comment
There was a problem hiding this comment.
Unfortunately this does not meet the PR requirements yet, please make sure the listed requirements are met.
Contributor
Author
|
Heya guys! Ooops, forgot this was still WIP. |
Contributor
|
@alexisfacques I am marking this PR as draft for now. Please mark it ready once you addressed previous comments. |
Contributor
|
Closing as inactive. Happy to review an updated PR from the community, if someone wants to revive the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Issue #2934
Why is this change necessary?
image_repository_validationfor Docker-packaged lambda functions with valid ECR locations (Issue Skip Docker Lambda image builds when ImageUri is a valid ECR location #2934, introduced in PR fix: Skip build of Docker image if ImageUri is a valid ECR URL (#2934) #2935);--guidedguided context prompts.DockerContextresource metadata prior to skipping the image build.How does it address the issue?
get_template_function_resource_ids,get_template_artifacts_format), use theSamFunctionProviderto do so (evaluating template parameters values, so the template must go through the IntrinsicResolver).What side effects does this change have?
get_template_function_resource_ids,get_template_artifacts_formatare obsolete (not yet deleted from the repo);Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.