chore: Update Ruby build integ test to reflect new lambda-builder beh…#3100
Closed
aahung wants to merge 6 commits intoaws:developfrom
Closed
chore: Update Ruby build integ test to reflect new lambda-builder beh…#3100aahung wants to merge 6 commits intoaws:developfrom
aahung wants to merge 6 commits intoaws:developfrom
Conversation
wchengru
approved these changes
Jul 21, 2021
c2tarun
approved these changes
Jul 22, 2021
8 tasks
Contributor
Author
|
@mildaniel I am closing this PR since we discussed about another fix to not testing this way. Let me know if you still want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…avior
Which issue(s) does this change fix?
Why is this change necessary?
Since aws/aws-lambda-builders#245, this integ test no longer expects build to fail
How does it address the issue?
Update the exit code and error message
What side effects does this change have?
Test only change
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.