Skip to content

fix: integration test case related to recent fix on ruby #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchengru merged 1 commit into from
Jul 30, 2021
Merged

fix: integration test case related to recent fix on ruby #3124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integration/buildcmd/test_build_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,8 +1132,8 @@ def test_with_wrong_builder_specified_python_runtime(self, use_container):

# runtime is chosen based off current python version.
runtime = self._get_python_version()
# BuildMethod is set to the ruby2.7, this should cause failure.
overrides = {"Runtime": runtime, "CodeUri": "Provided", "Handler": "main.handler", "BuildMethod": "ruby2.7"}
# BuildMethod is set to the java8, this should cause failure.
overrides = {"Runtime": runtime, "CodeUri": "Provided", "Handler": "main.handler", "BuildMethod": "java8"}
Copy link
Contributor

@hawflau hawflau Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did "ruby2.7" not work for this test case?

Copy link
Contributor Author

@wchengru wchengru Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently we have released a change to unblock Ruby users to build their project from requiring a manifest file. In this test case, the project is provided a python manifest but this will not fail Ruby builder.

Copy link
Contributor

@hawflau hawflau Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks!

manifest_path = os.path.join(self.test_data_path, "Provided", "requirements.txt")

cmdlist = self.get_command_list(
Expand Down