Import registered command to pyinstaller hook#3156
Merged
wchengru merged 11 commits intoaws:developfrom Aug 20, 2021
Merged
Conversation
CoshUS
suggested changes
Aug 17, 2021
jfuss
suggested changes
Aug 18, 2021
samcli/cli/command.py
Outdated
|
|
||
| return mod.cli | ||
|
|
||
| def get_command_packages(self): |
Contributor
There was a problem hiding this comment.
This looks like it is only used for testing. If so, is there no way to get this information through the tests?
Contributor
|
@wchengru This looks good to me. One follow up question: Did we test pyinstaller still works as we expect it to? Just being paranoid at this point. |
CoshUS
approved these changes
Aug 18, 2021
Contributor
Author
Yes, I have tested it locally and the pyinstaller works as expected. |
jfuss
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.