Skip to content

Import registered command to pyinstaller hook#3156

Merged
wchengru merged 11 commits intoaws:developfrom
wchengru:updatehiddenimports
Aug 20, 2021
Merged

Import registered command to pyinstaller hook#3156
wchengru merged 11 commits intoaws:developfrom
wchengru:updatehiddenimports

Conversation

@wchengru
Copy link
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wchengru wchengru changed the title fix: Import registered command to pyinstaller hook Import registered command to pyinstaller hook Aug 10, 2021

return mod.cli

def get_command_packages(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is only used for testing. If so, is there no way to get this information through the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this one.

@jfuss
Copy link
Contributor

jfuss commented Aug 18, 2021

@wchengru This looks good to me. One follow up question: Did we test pyinstaller still works as we expect it to? Just being paranoid at this point.

@wchengru
Copy link
Contributor Author

@wchengru This looks good to me. One follow up question: Did we test pyinstaller still works as we expect it to? Just being paranoid at this point.

Yes, I have tested it locally and the pyinstaller works as expected.

@wchengru wchengru merged commit c04386c into aws:develop Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants