fix: Add all files under samcli module#3177
Conversation
When we released the `sam pipeline` set of commands, we didn't update the MANIFEST.in file. This file controls what files get added or ignored when the .whl file is created. When we add non python files, we need to remember to update the MaNIFEST.in file. This commit will auto include any files within the samcli module but exlcude .pyc files. This might create a bigger .whl but will make sure the cli works going forward. I did some quick tests and compared 1.28 .whl to one I produced with this commit. I did not see any differences in the diff.
|
I haven't been able to replicate the failing unit test locally. Something is non-deterministic about |
| metric.get_data()["duration"], | ||
| sleep_duration, | ||
| "Measured duration must be in milliseconds and " "greater than equal to the sleep duration", | ||
| "Measured duration must be in milliseconds and greater than equal to the sleep duration", |
There was a problem hiding this comment.
| "Measured duration must be in milliseconds and greater than equal to the sleep duration", | |
| "Measured duration must be in milliseconds and greater than equal to the sleep duration", |
There was a problem hiding this comment.
Does the duration change break what this test is intended to check? The error message suggests this test is asserting that functions run less than 1 second should be recorded.
There was a problem hiding this comment.
I don't think so. My reasoning is that the test name is test_must_record_function_duration, which suggests it's scope it recording the duration. The comment is giving the explanation of why is failed, I don't think the duration actually matters for this test (other than asserting our duration is greater than the sleep_duration).
Update comment from ms to s Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
3 participants
When we released the
sam pipelineset of commands, we didn't updatethe MANIFEST.in file. This file controls what files get added or ignored
when the .whl file is created. When we add non python files, we need to
remember to update the MaNIFEST.in file. This commit will auto include
any files within the samcli module but exlcude .pyc files. This might
create a bigger .whl but will make sure the cli works going forward.
I did some quick tests and compared 1.28 .whl to one I produced with this
commit. I did not see any differences in the diff.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.