Skip to content

refactor(Delete): Refactor SAM Delete to Use Auto ECR#3195

Merged
CoshUS merged 3 commits intoaws:developfrom
CoshUS:feat/delete-auto-ecr-refactor-squashed
Aug 23, 2021
Merged

refactor(Delete): Refactor SAM Delete to Use Auto ECR#3195
CoshUS merged 3 commits intoaws:developfrom
CoshUS:feat/delete-auto-ecr-refactor-squashed

Conversation

@CoshUS
Copy link
Contributor

@CoshUS CoshUS commented Aug 23, 2021

Which issue(s) does this change fix?

Small PR to merge SAM Delete and Auto ECR.

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS CoshUS marked this pull request as ready for review August 23, 2021 07:24
@CoshUS CoshUS changed the title feat(Delete): Refactor SAM Delete to Use Auto ECR refactor(Delete): Refactor SAM Delete to Use Auto ECR Aug 23, 2021
Copy link
Contributor

@hawflau hawflau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoshUS CoshUS merged commit a282166 into aws:develop Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants