fix: Revert the behavior when both ImageUri and Metadata exist for im…#3272
Merged
aahung merged 2 commits intoaws:developfrom Sep 14, 2021
Merged
Conversation
awood45
approved these changes
Sep 14, 2021
Contributor
awood45
left a comment
awood45
left a comment
There was a problem hiding this comment.
This looks well-formed, let's make sure another lead agrees that this is the behavior we want going forward.
mndeveci
approved these changes
Sep 14, 2021
Contributor
mndeveci
left a comment
mndeveci
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this issue 👏🏼
hoffa
approved these changes
Sep 14, 2021
sriram-mv
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…age func
Which issue(s) does this change fix?
Why is this change necessary?
Fix #3239 by breaking change #2935
When both ImageUri and Metadata are provided, previously we choose to give "Metadata" the priority and build it. But now we skip it because ImageUri is provided.
How does it address the issue?
Fix the logics so that function is only skipped when ImageUri is provided and related fields cannot be found in Metadata. Previous behavior is partially recovered.
What side effects does this change have?
N/A
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.