Skip to content

Add support for the Node.js 8.10 Runtime #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulMaddox merged 2 commits into from
Apr 5, 2018
Merged

Add support for the Node.js 8.10 Runtime #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5ad08
Add support for the Node.js 8.10 Runtime
mhart Apr 3, 2018
ee1789f
Merge branch 'develop' into add-nodejs.810
PaulMaddox Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,10 +492,12 @@ sam local invoke --docker-volume-basedir /c/Users/shlee322/projects/test "Rating
- [x] `nodejs`
- [x] `nodejs4.3`
- [x] `nodejs6.10`
- [x] `nodejs8.10`
- [x] `java8`
- [x] `python2.7`
- [x] `python3.6`
- [ ] `dotnetcore1.0`
- [x] `dotnetcore2.0`
* [x] AWS credential support
* [x] Debugging support
* [x] Inline Swagger support within SAM templates
Expand Down
17 changes: 17 additions & 0 deletions runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ var runtimeName = struct {
nodejs string
nodejs43 string
nodejs610 string
nodejs810 string
python27 string
python36 string
java8 string
Expand All @@ -90,6 +91,7 @@ var runtimeName = struct {
nodejs: "nodejs",
nodejs43: "nodejs4.3",
nodejs610: "nodejs6.10",
nodejs810: "nodejs8.10",
python27: "python2.7",
python36: "python3.6",
java8: "java8",
Expand All @@ -101,6 +103,7 @@ var runtimeImageFor = map[string]string{
runtimeName.nodejs: "lambci/lambda:nodejs",
runtimeName.nodejs43: "lambci/lambda:nodejs4.3",
runtimeName.nodejs610: "lambci/lambda:nodejs6.10",
runtimeName.nodejs810: "lambci/lambda:nodejs8.10",
runtimeName.python27: "lambci/lambda:python2.7",
runtimeName.python36: "lambci/lambda:python3.6",
runtimeName.java8: "lambci/lambda:java8",
Expand Down Expand Up @@ -502,6 +505,20 @@ func (r *Runtime) getDebugEntrypoint() (overrides []string) {
"--expose-gc",
"/var/runtime/node_modules/awslambda/index.js",
)
case runtimeName.nodejs810:
overrides = []string{
"/var/lang/bin/node",
}
overrides = append(overrides, debuggerArgsArray...)
overrides = append(overrides,
"--inspect="+r.DebugPort,
"--debug-brk",
"--nolazy",
"--expose-gc",
"--max-semi-space-size=150",
"--max-old-space-size=2707",
"/var/runtime/node_modules/awslambda/index.js",
)
case runtimeName.python27:
overrides = []string{
"/usr/bin/python2.7",
Expand Down