fix: make routeKey and queryStringParameters for local HttpApi event match deployed one #3497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/local/invoke
awood45
suggested changes
Dec 16, 2021
awood45
approved these changes
Dec 16, 2021
mildaniel
approved these changes
Dec 21, 2021
hawflau
approved these changes
Dec 21, 2021
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…match deployed one (aws#3497) * fix: make routeKey and queryStringParameters for local HttpApi event match deployed ones * update test default Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#3463
Why is this change necessary?
routeKeyandqueryStringParametersfrom HttpApi event when runningsam local start-apidon't match the event from the deployed api. More info is in the linked issue.How does it address the issue?
Makes them match (make
routeKeyuse curly brackets and removequeryStringParametersif there's no query params)What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.