fix: Add ECR Policy Check to Integration Tests#3527
Merged
CoshUS merged 9 commits intoaws:developfrom Jan 10, 2022
Merged
Conversation
qingchm
reviewed
Dec 11, 2021
qingchm
reviewed
Dec 11, 2021
| self.assertEqual(lambda_policy.get("Principal"), {"Service": "lambda.amazonaws.com"}) | ||
| actions = lambda_policy.get("Action") | ||
| self.assertEqual( | ||
| sorted(actions), sorted(["ecr:GetDownloadUrlForLayer", "ecr:GetRepositoryPolicy", "ecr:BatchGetImage"]) |
Contributor
There was a problem hiding this comment.
["ecr:GetDownloadUrlForLayer", "ecr:GetRepositoryPolicy", "ecr:BatchGetImage"] is this list stored somewhere in our codebase? Would be nice if this is an import and any changes to our ECR policies won't need an update on this test
Contributor
Author
There was a problem hiding this comment.
It's hard coded in the template generation part.
Not importing in the test as this test acts as a sanity check for any changes to the ECR policy.
Contributor
|
LGTM! Just two small comments! |
qingchm
approved these changes
Dec 11, 2021
mndeveci
approved these changes
Jan 6, 2022
…am-cli into fix/ecr-policy-test
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
* Added ECR Policy Check Tests * Updated Dict Get Default * Added Companion Stack Asserts to PackageIntegBase Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.