-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: allow sam to deploy templates contain CFN Lambda Function resources with Image package type, and its code is local image uri. #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
moelasmar
merged 10 commits into
aws:develop
from
moelasmar:develop-fix-sam-deploy-cfn-lambda-function-image
Dec 22, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rces with Image package type, and its code is local image uri,
mndeveci
reviewed
Dec 15, 2021
torresxb1
reviewed
Dec 15, 2021
tests/integration/testdata/buildcmd/template_cfn_local_prebuilt_image.yaml
Outdated
Show resolved
Hide resolved
torresxb1
reviewed
Dec 15, 2021
tests/integration/testdata/buildcmd/template_local_prebuilt_image.yaml
Outdated
Show resolved
Hide resolved
wchengru
approved these changes
Dec 22, 2021
hawflau
approved these changes
Dec 22, 2021
moelasmar
added a commit
to moelasmar/aws-sam-cli
that referenced
this pull request
Dec 22, 2021
…ces with Image package type, and its code is local image uri. (aws#3529) * (fix) allow sam to deploy templates contain CFN Lambda Function resources with Image package type, and its code is local image uri, * make reformat * (fix) fix sam build failure for templates contians function without Docker Metadata * run black format * resolve PR comments
moelasmar
added a commit
to moelasmar/aws-sam-cli
that referenced
this pull request
Dec 30, 2021
…ces with Image package type, and its code is local image uri. (aws#3529) * (fix) allow sam to deploy templates contain CFN Lambda Function resources with Image package type, and its code is local image uri, * make reformat * (fix) fix sam build failure for templates contians function without Docker Metadata * run black format * resolve PR comments
|
Is it intentional that SAM CLI is now requiring both I'm not clear on the reasoning here but it seems like it would be better to require either property rather than both. |
okofish
added a commit
to WolframResearch/AWSLambda-WolframLanguage
that referenced
this pull request
Jan 25, 2022
…ix template breakage caused by aws/aws-sam-cli#3529
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…ces with Image package type, and its code is local image uri. (aws#3529) * (fix) allow sam to deploy templates contain CFN Lambda Function resources with Image package type, and its code is local image uri, * make reformat * (fix) fix sam build failure for templates contians function without Docker Metadata * run black format * resolve PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
sam deploy fail to deploy the a template that contains Lambda function with Image Package Type, and refer to a local image uri. example template:
This PR also fixes sam build for the same template.
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.