feat: allow invoking built CDK synthesized templates#3549
Merged
moelasmar merged 13 commits intoaws:developfrom Dec 30, 2021
Merged
feat: allow invoking built CDK synthesized templates#3549moelasmar merged 13 commits intoaws:developfrom
moelasmar merged 13 commits intoaws:developfrom
Conversation
…e-built-cdk-templates' into develop-invoke-built-cdk-templates
mndeveci
reviewed
Dec 29, 2021
…e-built-cdk-templates' into develop-invoke-built-cdk-templates
mndeveci
reviewed
Dec 30, 2021
| ) | ||
| return customer_defined_id | ||
|
|
||
| resource_cdk_path = resource_metadata.get(RESOURCE_CDK_PATH_METADATA_KEY) |
Contributor
There was a problem hiding this comment.
This method and filename is named generic (resource_metadata_normalizer and get_resource_id), but method itself contains CDK specific stuff. This feels like it should be a generic (let's say ResourceMetadataNormalizer) class and we should be assigning different types depending on the project type (CfnResourceMetadataNormalizer or CdkResourceMetadataNormalizer), what do you think?
Contributor
Author
There was a problem hiding this comment.
I am working on another PR that is related to this part (IaC ids) to use it in other commands. Can I work on this refactoring after I merge this PR, and the one I am working on, as I do not want to miss things, it will be easier to refactor everything together
mndeveci
approved these changes
Dec 30, 2021
mildaniel
approved these changes
Dec 30, 2021
…p-invoke-built-cdk-templates # Conflicts: # tests/unit/lib/samlib/test_resource_metadata_normalizer.py
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
* feat: allow invoking built CDK synthesized templates * run black * fixing testing issue * add unit testing to cover custom resource Id * run black * skip normalizing the resources that have been normalized before * apply pr comments * apply pr comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
allow invoking built CDK synthesized templates
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.