feat: Add support resources full path, and CDK construct ids to support CDK, and nested stacks #3560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/internal
area/build
moelasmar
added
area/accelerate
area/nested-stacks
and removed
area/local/start-api
wchengru
approved these changes
Jan 3, 2022
hawflau
reviewed
Jan 3, 2022
samcli/lib/build/build_graph.py
Outdated
| ---------- | ||
| function_logial_id : str | ||
| function_full_path : str | ||
| Function logical id that will be searched in the function build definitions |
Contributor
There was a problem hiding this comment.
nit: update the param description as well
apply pr comments
hawflau
approved these changes
Jan 3, 2022
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…rt CDK, and nested stacks (aws#3560) * use Iac Id, and Full Path for Functions and Layers * use Iac Id, and Full Path for stacks * use full path and CDK Id for image repositories validation * allow using full_path and CDK ids in sam sync, package, deploy * add CDK and nested CDK stacks integration test cases, and fix some issues * Update build_graph.py apply pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.